Add yac interface to couple to ICON #683
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dsidoren @sveta-loza Can we sort out what needs to be done for merging this. |
JanStreffing
requested changes
Feb 12, 2025
There was a problem hiding this comment.
First, the checks are failing:
https://github.com/FESOM/fesom2/actions/runs/13158564989/job/36721281053?pr=683#step:6:915
/__w/fesom2/fesom2/src/gen_forcing_couple.F90:276:9:
276 | end do
| 1
Error: Expecting END SUBROUTINE statement at (1)After that goes through I'll give this branch a try as coupled to openifs through oasis. Then someone also needs to test coupled to echam through oasis. @christian-stepanek maybe?
| ! oifs/echam | ||
| #endif | ||
| ! oasis | ||
| #endif ! oifs/echam |
There was a problem hiding this comment.
I don't think all compiler will allow comments on the end of preprocessor statements. This would be reverted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds yac as a coupling library to FESOM, such that it can be coupled to ICON.