Add pedantic flag for wrapper build. (#899)

* Add pedantic flag for wrapper build. Bump nanobind version to 2.5.0. * Disable warning
FEniCS · Feb 9, 2025 · cbd03dc · cbd03dc
1 parent d7bb763
commit cbd03dc
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 6 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -1,5 +1,5 @@
 [build-system]
-requires = ["scikit-build-core[pyproject]>=0.10.0", "nanobind>=2.0.0"]
+requires = ["scikit-build-core[pyproject]>=0.10.0", "nanobind>=2.5.0"]
 build-backend = "scikit_build_core.build"
 
 [project]

diff --git a/python/CMakeLists.txt b/python/CMakeLists.txt
@@ -30,16 +30,15 @@ list(APPEND CMAKE_PREFIX_PATH "${NB_DIR}")
 find_package(nanobind CONFIG REQUIRED)
 
 # Create the binding library
-nanobind_add_module(_basixcpp wrapper.cpp)
+nanobind_add_module(_basixcpp NB_SUPPRESS_WARNINGS wrapper.cpp)
 target_compile_definitions(_basixcpp PRIVATE cxx_std_20)
 target_link_libraries(_basixcpp PRIVATE Basix::basix)
 
 # Add strict compiler flags
 include(CheckCXXCompilerFlag)
-CHECK_CXX_COMPILER_FLAG("-Wall -Werror -Wextra -Wno-comment -pedantic" HAVE_PEDANTIC)
-
+check_cxx_compiler_flag("-Wall -Werror -Wextra -pedantic" HAVE_PEDANTIC)
 if(HAVE_PEDANTIC)
-  target_compile_options(_basixcpp PRIVATE -Wall;-Wextra;-Werror;-Wno-comment)
+  target_compile_options(_basixcpp PRIVATE -Wall;-Werror;-Wextra;-Wno-comment;-pedantic)
 endif()
 
 # TODO: remove after issue https://github.com/FEniCS/basix/issues/842 is resolved

diff --git a/python/pyproject.toml b/python/pyproject.toml
@@ -1,5 +1,5 @@
 [build-system]
-requires = ["scikit-build-core[pyproject]>=0.10.0", "nanobind>=2.0.0"]
+requires = ["scikit-build-core[pyproject]>=0.10.0", "nanobind>=2.5.0"]
 build-backend = "scikit_build_core.build"
 
 [project]