-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add demo of stokes with various stable pairs of finite elements #2505
Conversation
I like this! My only comment would be that it would be good to show the lowest-order pressure-robust Scott-Vogelius finite element pair. |
Thanks! The Scott-Vogelius element is only (provably) int-sup stable for k = 4 ( https://doi.org/10.1051/m2an/1985190101111) so I would propose using a higher-order for the demo. |
Thank you for the feedback! I added the Scott-Vogelius element using the iterative procedure explained in the FEniCS book in chapter 20.3. |
Does this demo exhibit any dolfinx functionality that's not already shown in other demos? E.g. https://github.com/FEniCS/dolfinx/blob/main/python/demo/demo_lagrange_variants.py and https://github.com/FEniCS/dolfinx/blob/main/python/demo/demo_stokes.py? Also consider https://github.com/jorgensd/fenics22-tutorial/blob/main/comparing_elements.ipynb. |
The goal of this demo was to show an While the existing Stokes demo focuses on different algebraic solvers, different finite element types are compared here.
Thanks for the tip! I did not know this tutorial before. I think the convergence studies are very informative. I would love to extend this demo accordingly. |
For every demo added, there's a burden of maintenance for the developers. This demo only shows element enrichment which has overloaded the Otherwise I think the rest of the demo is an interesting report of various numerical methods which would be better hosted as part of a tutorial or personal portfolio. |
Remained open for some time, so closing. |
There is already a demo of the Stokes equations for the lid driven cavity scenario with Taylor-Hood elements: https://docs.fenicsproject.org/dolfinx/main/python/demos/demo_stokes.html
Based on this, I have created a demo using various stable pairs of finite elements. So far these are:
With the MINI element, an enriched finite element is also used in a demo now. Such a demo was requested in #2312.
I think this demo would be helpful for beginners who want to try new finite elements.
Since this is my first contribution to dolfinx I would appreciate any feedback.