Some updates for mesh generation #3275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorgensd
reviewed
Jun 21, 2024
cpp/dolfinx/mesh/generation.h
Outdated
| // Create tetrahedra | ||
| for (std::int64_t i = range_c[0]; i < range_c[1]; ++i) | ||
| { | ||
| const std::int64_t iz = i / (nx * ny); |
There was a problem hiding this comment.
We usually dont use const assignment for integers. Maybe @garth-wells can comment?
There was a problem hiding this comment.
House style is we don't normally use const for owned variables inside functions.
There was a problem hiding this comment.
So remove const in these cases? They were marked const before this PR.
garth-wells
requested changes
Jun 29, 2024
cpp/dolfinx/mesh/generation.h
Outdated
| // Create tetrahedra | ||
| for (std::int64_t i = range_c[0]; i < range_c[1]; ++i) | ||
| { | ||
| const std::int64_t iz = i / (nx * ny); |
There was a problem hiding this comment.
House style is we don't normally use const for owned variables inside functions.
|
|
garth-wells
reviewed
Jul 15, 2024
schnellerhase
force-pushed
the
create_rectangle
branch
3 times, most recently
from
1109985
to
0737629
Compare
* Fix cmake * Implement a one dimensional refinement routine * Change to assert * Switch to ghost mode by user choice * Switch naming from 'edges' to 'cells' * More 'edge' -> 'cell' * Add parameter of intervals and explicit data type * Bug fix in test * Remove vector<bool> comment * Capitalization of comments * Split -> refined * Doc string * Fix edge confusion * Switch to ghost mode default shared_facet * Fix float comparison * Fix typo * Fix type * Remove auto * Add brackets for readability
* Rename interval refinement test file Pytest discovery previously ignored the interval test case, since it did not match the expected `test_` naming scheme * Fix: implicit ghost_mode of interval mesh made explicit * Fix: Bug for parallel interval refinement Caused by assumption that ghost cells are refined on the process as well, which is not the case -> job of remote process that owns it
schnellerhase
force-pushed
the
create_rectangle
branch
from
0737629
to
a49666b
Compare
|
Fixed the wrong git setup in the initial commits. |
garth-wells
approved these changes
Sep 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading up on the mesh generation I had quite a hard time to understand what was going on in
generation.h. This contains some tidying up of the code and relocation of input checks to more central positions.What this PR does not change but should be done in the future is (if PR gets accepted I'll make this a new issue)
create_interval,create_rectangleandcreate_box