Remove `build-requirements.txt` #3955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

jhale merged 19 commits into main from schnellerhase/remove-build-requirements

Oct 23, 2025

Contributor

schnellerhase commented Oct 19, 2025 •

edited

Loading

Instead of maintaining a duplicate list of build dependencies in build-requirements.txt, these are now deduced from the listing in pyproject.toml.

Fixes #3869.


          Remove build-requirements

f267a85

schnellerhase changed the title ~~Remove build-requirements~~ Remove build-requirements.txt

schnellerhase commented

View reviewed changes

.github/workflows/ccpp.yml Outdated Show resolved Hide resolved

schnellerhase added 3 commits

October 19, 2025 13:53


          Apply suggestion from @schnellerhase

fb77acf


          Fine tune

e660d34


          Install scikit before

e48f6ac

schnellerhase commented

View reviewed changes

.github/workflows/ccpp.yml Outdated Show resolved Hide resolved

.github/workflows/ccpp.yml Outdated Show resolved Hide resolved

.github/workflows/ccpp.yml Outdated Show resolved Hide resolved

.github/workflows/clang-tidy.yml Outdated Show resolved Hide resolved

.github/workflows/macos.yml Outdated Show resolved Hide resolved

.github/workflows/windows.yml Outdated Show resolved Hide resolved

docker/Dockerfile.end-user Outdated Show resolved Hide resolved

python/doc/source/installation.rst Outdated Show resolved Hide resolved

python/README.md Outdated Show resolved Hide resolved

README.md Outdated Show resolved Hide resolved


          Apply suggestions from code review

9de6d05

schnellerhase added the build label


          Align build dependencies

7dbc438

schnellerhase marked this pull request as ready for review

October 19, 2025 12:39

schnellerhase requested review from jhale, jorgensd and michalhabera

October 19, 2025 12:40

schnellerhase commented

View reviewed changes

.github/workflows/macos.yml Show resolved Hide resolved

schnellerhase commented

View reviewed changes

.github/workflows/windows.yml Outdated Show resolved Hide resolved


          Apply suggestions from code review

7429c54

schnellerhase commented

View reviewed changes

.github/workflows/windows.yml Outdated Show resolved Hide resolved

schnellerhase commented

View reviewed changes

.github/workflows/macos.yml Show resolved Hide resolved


          Apply suggestions from code review

02feca2

schnellerhase commented

View reviewed changes

.github/workflows/macos.yml Outdated Show resolved Hide resolved


          Update .github/workflows/macos.yml

505e340

Member

jhale commented Oct 19, 2025

Looks good but remember for the instructions the user is going to need scikit-build-core to be installed.

schnellerhase commented

View reviewed changes

README.md Show resolved Hide resolved

python/README.md Show resolved Hide resolved

schnellerhase added 6 commits

October 19, 2025 17:36


          Apply suggestions from code review

a06f633


          Fix windows?

608e318


          Step by step

212c8b4


          Found?

ed4f125


          Merge branch 'main' into schnellerhase/remove-build-requirements

ba26210


          Merge branch 'main' into schnellerhase/remove-build-requirements

769bc60

Member

jhale commented Oct 23, 2025

Happy to merge this. I leave a comment that pip has a draft PR open which may eventually remove the need for this:

jhale reviewed

View reviewed changes

python/pyproject.toml Outdated Show resolved Hide resolved

schnellerhase added 4 commits

October 23, 2025 12:30


          Merge branch 'main' into schnellerhase/remove-build-requirements

e37cbce


          Remove build dependency setuptools, ufl install without build isolation

003ea1a


          Add install to CI

8ef50e7


          Merge branch 'main' into schnellerhase/remove-build-requirements

7504f04

jhale approved these changes

View reviewed changes

jhale added this pull request to the merge queue

Merged via the queue into main with commit 6037ceb

18 of 19 checks passed

jhale deleted the schnellerhase/remove-build-requirements branch

October 23, 2025 20:22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build