Emmarothwell1/restricted function space #252
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trimmed serendipity
Merge fenics
Merge FEniCS
Ksagiyam/merge upstream
Update to current fenics master.
remove spurious names
Dolci/merge upstream 2
…date Merge upstream
dham
commented
Jan 30, 2024
ufl/functionspace.py
Outdated
| @@ -50,11 +50,16 @@ def __init__(self, domain, element): | |||
| else: | |||
| if element.cell != domain_cell: | |||
| raise ValueError("Non-matching cell of finite element and domain.") | |||
|
|
|||
ufl/functionspace.py
Outdated
| @@ -80,6 +85,7 @@ def _ufl_hash_data_(self, name=None): | |||
| name = name or "BaseFunctionSpace" | |||
| domain = self.ufl_domain() | |||
| element = self.ufl_element() | |||
| bdata = self.label() | |||
There was a problem hiding this comment.
I guess we don't need this variable, just directly use self.label below.
ufl/functionspace.py
Outdated
|
|
||
| def _ufl_signature_data_(self, renumbering, name=None): | ||
| """UFL signature data.""" | ||
| name = name or "BaseFunctionSpace" | ||
| domain = self.ufl_domain() | ||
| element = self.ufl_element() | ||
| bdata = self.label() |
mscroggs
reviewed
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for function space labels in order to support symbolically different function spaces on the same element and domain. An example are restricted function spaces.