-
-
Notifications
You must be signed in to change notification settings - Fork 258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should we add this list ? #117
Comments
Yes, lots of good stuff there. |
I was about to submit a PR, after diff'ing for unique hosts. |
@datio I would happily accept this PR.
I'm not sure about that but I'm not an expert in that field, what are the consequences of such affirmation? |
I was worried about the license incompatibilities between the two open source licenses. For example, the nfedyashev/valid_email2's disposable emails list which has been included in this project is under the same MIT license, so with proper attribution there shouldn't be a problem (we still miss that person's copyright.txt file from their repository though, so unless the person who submitted that PR is also the original creator of it, we're still in a grey area). Another example is the list included from Disposable/spam email collections have a strong similarity to IP-to-location database dumps, such as GeoLite2. I believe the companies that provide and update such databases strongly enforce their copyrights, especially for their premium databases. |
The merged list increases the covering to 4550 unique email hosts. |
Add 2144 hosts from ivolo/disposable-email-domains, closes #117
https://github.com/yclas/yclas/blob/master/oc/banned_domains.json
What do you think?
The sad part is that it does not only include fake emails
The text was updated successfully, but these errors were encountered: