Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add this list ? #117

Closed
FGRibreau opened this issue Nov 22, 2017 · 5 comments
Closed

Should we add this list ? #117

FGRibreau opened this issue Nov 22, 2017 · 5 comments
Labels

Comments

@FGRibreau
Copy link
Owner

https://github.com/yclas/yclas/blob/master/oc/banned_domains.json

What do you think?
The sad part is that it does not only include fake emails

@benjamingr
Copy link

Yes, lots of good stuff there.

@datio
Copy link
Contributor

datio commented Jan 1, 2018

I was about to submit a PR, after diff'ing for unique hosts.
yclas is a GPL3 licensed project, is it ok to just merge the spam list into this MIT licensed project?
I've noticed attribution is always provided in the list.json. Can this file be considered derivative work?

@FGRibreau
Copy link
Owner Author

@datio I would happily accept this PR.

I've noticed attribution is always provided in the list.json Can this file be considered derivative work?

I'm not sure about that but I'm not an expert in that field, what are the consequences of such affirmation?

@datio
Copy link
Contributor

datio commented Jan 1, 2018

I was worried about the license incompatibilities between the two open source licenses.
The GPL is more "viral", in a sense that it requires all the derivative works to be released under the same viral license, whereas the MIT license doesn't pose such a requirement and is less restrictive.

For example, the nfedyashev/valid_email2's disposable emails list which has been included in this project is under the same MIT license, so with proper attribution there shouldn't be a problem (we still miss that person's copyright.txt file from their repository though, so unless the person who submitted that PR is also the original creator of it, we're still in a grey area).

Another example is the list included from http://xenforo.com/community/threads/ban-temporary-email-addresses.5461/
That list was created by collecting information shared by users in a forum. Even though the commiter probably didn't request consent from those users, his work in collecting and checking the links can be thought as original. The commiter even gave proper attribution to the source with the commented link.
As a sidenote, the resulted list can now be used by the participants of that same forum -who are mostly forum owners- as the MailChecker list.json is available for them to use, so it's a win-win situation.

Disposable/spam email collections have a strong similarity to IP-to-location database dumps, such as GeoLite2. I believe the companies that provide and update such databases strongly enforce their copyrights, especially for their premium databases.
The list in the yclas/yclas repository is a ready to use list already. We should think of it as "proprietary" (due to the license incompatibility), as we have no consent from its copyright yet to merge it with ours.

@datio
Copy link
Contributor

datio commented Jan 2, 2018

The merged list increases the covering to 4550 unique email hosts.

FGRibreau added a commit that referenced this issue Jan 3, 2018
Add 2144 hosts from ivolo/disposable-email-domains, closes #117
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants