Modernize en Optimize (A LOT) PHP platform #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use an external file to be able to run static analysis tool (ATM, analyzer crash because the file is too big) * Enable the opcache caching feature (better for the RAM) * Use key instead of value when searching in the array * Add type hint everywhere * Use generator to lazy load evualuation as much as possible
|
Hey :) Nice upgrade however this is going to be a breaking change so I will release a new major version 👍 |
|
Released in v4.0.0 👍 thanks :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, It's me again. I used this project in one of my application, and ... bad news. Our static analyzer (very famous, very used) crash because the file is way too big.
I wanted to do this PR a while ago, because the project is nice, but the PHP code was a bit "old" 😄
So here is what I did:
analyzer crash because the file is too big)
Results are ❤️ ! For the current test suite, on my computer:
Before: Time: 36.94 seconds, Memory: 68.51 MB
After: Time: 2.78 seconds, Memory: 66.51 MB
😎