-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add dependency notes file #37
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small question. It looks like moment
is on v2.30.1 and the package-lock.json
has already been updated to use that version. Are we trying to keep the package.json
list updated with the latest versions we're using as well? If so, we can update that file. On the other hand, package-lock.json
is doing what it is supposed to do, it probably isn't a huge deal either way.
I think it's okay? |
Yeah, that's why I wasn't sure if we needed it. But the |
Yeah, I think it's technically OK. It's kind of nice when the package.json reflects the latest as of the time you did the updates -- but it's not necessary. There are probably other cases in our other packages where this happens but it's not as obvious because there are so many more dependencies in those ones. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Easy peasy. Thanks Mint!
Description:
Adds the dependency notes file to track dependencies that are intentionally left out of date. All dependencies are currently up-to-date, so there are no dependencies listed in the file.
Related Issue:
Fixes #35