Add tutorial files #100
Merged
Add tutorial files #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tutorial files that were previously kept in another repository are added locally. The fsh-tutorial directory contains these files. Add step to the github action for deploying the site that rebuilds the tutorial zip.
jafeltra
reviewed
Jul 30, 2024
Add section to README about rebuilding the tutorial zip. Use the script in the deployment action. Tutorial zip is rebuilt, but there are no changes to the contents. I think there may be some nondeterministic components in this file.
jafeltra
approved these changes
Sep 6, 2024
There was a problem hiding this comment.
This looks good to me! I ran the zip-tutorial script and it worked well on my computer. When I run it, git does show it as changed, but I think that's fine. I also confirmed that the zip that's checked in works on my computer, and it seems to work without any issues.
So I think this is good to go! Thanks for adding the script!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tutorial files that were previously kept in another repository are added locally. The fsh-tutorial directory contains these files.
Add step to the github action for deploying the site that rebuilds the tutorial zip.