Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move FSHSchool site to GitHub FHIR organization #105

Merged
merged 2 commits into from
Sep 21, 2024
Merged

Conversation

cmoesel
Copy link
Member

@cmoesel cmoesel commented Sep 13, 2024

Description: This PR contains necessary updates to support moving this repo (and FSHOnline) to the github.com/FHIR organization. Changes include:

  • Replace links as necessary to point to correct locations for FSHOnline, FSH Finder, and Courses.
  • Update GitHub links to point to new location of site repo.
  • Update deployment to deploy to gh-pages branch (default) instead of separate fshschool.github.io repo.
  • Add custom 404 page to automatically redirect link to /FSHOnline, /fsh-finder, and /courses to their new web locations. (Note, redirects only work on GH pages; they do not work for local deployment).

This PR should not be merged until the repos have been moved. Assuming the fshschool.org apex domain has been configured as described here, no further configuration should be necessary (aside from what is described in the corresponding FHIR/FSHOnline#184 PR).

Testing Notes: Until the repositories are moved and domains are reconfigured, links to FSHOnline are not expected to work. Links for FSH Finder and Courses should work before and after the move. As for the custom 404 page, custom redirects will not work when serving from Hugo; they only work from web servers that automatically serve the 404.html page for unfound paths (like GH pages does).

Related Issue: N/A

* Replace links as necessary to point to correct locations for FSHOnline, FSH Finder, and Courses.
* Update GitHub links to point to new location of site repo.
* Update deployment to deploy to gh-pages branch (default) instead of separate fshschool.github.io repo.
* Add custom 404 page to automatically redirect link to /FSHOnline, /fsh-finder, and /courses to their new web locations. (Note, redirects only work on GH pages; they do not work for local deployment).
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes make sense to me! I couldn't really test the redirects, but they make sense in the code and the updated links look correct.

.github/workflows/deploy.yaml Show resolved Hide resolved
@cmoesel cmoesel marked this pull request as ready for review September 21, 2024 15:40
@cmoesel cmoesel merged commit c94774e into master Sep 21, 2024
@cmoesel cmoesel deleted the move-fsh-school branch September 21, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants