-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logical model examples without resourceType or id #86
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good and is explained clearly. Thanks!
I've updated this PR to use the current extension URL for IG resource format, since the one we had documented has been deprecated. I've also updated it use a full canonical URL in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've asked a question / suggested a change. Technically the example is not wrong, so I couldn't make myself select Request Changes
-- but it's probably a good idea to change it anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
This PR adds a note to the Tips and Tricks section about logical model examples without resource type and id. I wasn't exactly sure where this should fit because it is really similar to the existing documentation. Let me know what you think.
Note: this approach is based on discussion on Zulip here.
Do not merge this PR until there is a SUSHI release that includes support for this.