Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot roundtrip R5 workflow reason extension #220

Closed
vadi2 opened this issue May 11, 2023 · 1 comment · Fixed by #229
Closed

Cannot roundtrip R5 workflow reason extension #220

vadi2 opened this issue May 11, 2023 · 1 comment · Fixed by #229
Labels
bug Something isn't working

Comments

@vadi2
Copy link

vadi2 commented May 11, 2023

Roundtripping workflow-reason from R5 doesn't work, both in fshonline and gofsh on the CLI:

gofsh --indent --useFHIRVersion 5.0.0
sushi
// ...
info  Converting FSH to FHIR resources...
error Cannot bind value set to Reference; must be coded (code, Coding, CodeableConcept, Quantity, CodeableReference), or the data types (string, uri).
  File: .../gofsh/input/fsh/extensions/WorkflowReason.fsh
  Line: 33

The R4 version of the extension does pass without errors (just a warning).

@cmoesel
Copy link
Member

cmoesel commented May 11, 2023

Hi @vadi2. Good catch! You're absolutely correct. It looks like GoFSH needs to be updated to recognize CodeableReference as a valid type to receive a binding. Thank you for reporting this.

I'm going to transfer this issue to the GoFSH repository since it's related to that code base.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
2 participants