Extract more specific types in OnlyRules with target profiles #229
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference, CodeableReference, and canonical types can all be specified with target profiles. When extracting an OnlyRule, set the corresponding boolean value on the extracted type along with the target profiles. This takes advantage of the newly available isCodeableReference flag on SUSHI's OnlyRuleType.
cmoesel
approved these changes
Jul 17, 2023
| @@ -9,9 +10,17 @@ export class OnlyRuleExtractor { | |||
| } | |||
| const onlyRule = new ExportableOnlyRule(getPath(input)); | |||
| input.type.forEach((t, i) => { | |||
| if (['Reference', 'CodeableReference'].includes(t.code) && t.targetProfile) { | |||
| if (['Reference', 'CodeableReference', 'canonical'].includes(t.code) && t.targetProfile) { | |||
| const targeting: Partial<fshrules.OnlyRuleType> = {}; | |||
There was a problem hiding this comment.
Oooh. We haven't leveraged Partial much before. Cool.
jafeltra
approved these changes
Jul 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #220 and completes task CIMPL-1100.
Reference, CodeableReference, and canonical types can all be specified with target profiles. When extracting an OnlyRule, set the corresponding boolean value on the extracted type along with the target profiles. This takes advantage of the newly available isCodeableReference flag on SUSHI's OnlyRuleType.
The changes in this PR ended up going a bit beyond the original task description, as I noticed that GoFSH was handling canonical types with target profiles by creating caret rules. But, everything appears to round-trip cleanly, so I thought it would be best to clean up all these types together.