SUSHI 3.0.0 + Relevant Features #222
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Replace loadDependency and loadFromPath functions with FPL functions * Add FPL package and repository field * Use mergeDependency function and update tests * Use FPL FHIRDefinitions class with a simpler fishForMetadata implementation * Update to reflect latest changes in SUSHI * Add log function to pass in to FPL functions
* Create inline instances with numeric ids * Use node 16, 18 for automated testing * Update test for numeric id
* Handle numeric element names Elements are allowed to have numeric names. When flattening an object, array indices get put into square brackets, but numeric element names do not. This keeps the paths intact when checking types and writing assignment or caret value rules. * fix parameter name * Use node 16, 18 for automated testing * Add test for processing Instance with numeric paths Add test for extracting caret rules on an array element containing an empty object. Update tool versions. Improve implementation of getPathValuePairs.
mint-thompson
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR to include SUSHI 3.0.0 and the latest FPL release, along with the features we've implemented to support those releases.
All these changes have been reviewed except for the last two commits (
bd2c4d0andbc7b0b3), which actually update the package versions.