Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

To v2.0.1 #227

Merged
merged 4 commits into from
Jul 11, 2023
Merged

To v2.0.1 #227

merged 4 commits into from
Jul 11, 2023

Conversation

jafeltra
Copy link
Collaborator

This PR preps for the next GoFSH release with the following steps:

  • Bumped SUSHI to the latest 3.1.0
  • Ran npm audit fix to fix what could be fixed
  • Bumped the version to 2.0.1

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed that semver still causes issues w/ audit. I'd recommend you do the same as I did for SUSHI and use overrides to force it to the latest. I reviewed the change logs and the only notable differences between 6 and 7 was a change in requirements for Node.js -- so it should be safe.

In this case, since we're using semver directly, I'd start by updating it directly:

npm install semver@latest

and then add the override referencing the dependency version:

"overrides": {
  "semver": "$semver"
}

@jafeltra
Copy link
Collaborator Author

Good point, @cmoesel! I just updated to include those changes. Let me know what you think.

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good!

@jafeltra jafeltra merged commit 4f1c7c0 into master Jul 11, 2023
@jafeltra jafeltra deleted the to-v2.0.1 branch July 11, 2023 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants