Load the same automatic dependencies as SUSHI #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use SUSHI's function for loading automatic dependencies. There is a minor discrepancy in the expected type, but the FHIR definitions are only passed in so they can be passed to fhir-package-loader's mergeDependency function. So, the ts-ignore here should be safe. Add a note indicating the reason for the ts-ignore and the conditions under which it can be removed.
jafeltra
reviewed
Jul 17, 2023
All dependency loading is now handled by loadExternalDependencies. This function is used in both command-line and API modes. This function determines the core FHIR package, loads automatic dependencies (as defined by SUSHI), and loads configured dependencies.
jafeltra
reviewed
Jul 19, 2023
jafeltra
previously approved these changes
Jul 24, 2023
cmoesel
requested changes
Jul 24, 2023
package.json
Outdated
| @@ -73,7 +73,7 @@ | |||
| "diff": "^5.0.0", | |||
| "diff2html": "^3.1.18", | |||
| "fhir": "^4.10.0", | |||
| "fhir-package-loader": "^0.3.0", | |||
| "fhir-package-loader": "^0.4.0", | |||
There was a problem hiding this comment.
FPL is at v0.5.0 now, so... since you're bumping this anyway, might as well bump it to the latest.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completes task CIMPL-1113.
Use SUSHI's function for loading automatic dependencies. There is a minor discrepancy in the expected type, but the FHIR definitions are only passed in so they can be passed to fhir-package-loader's mergeDependency function. So, the ts-ignore here should be safe. Add a note indicating the reason for the ts-ignore and the conditions under which it can be removed.