Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Process ValueSet that uses components from a contained system #275

Merged
merged 1 commit into from
Nov 13, 2024

Conversation

mint-thompson
Copy link
Collaborator

Description:
When a ValueSet component references a contained system, the valueset-system extension should be present at compose.system.extension. When it is present, it is safe to throw it out, since SUSHI will add it back in automatically. When it is removed, also remove the extension list and containing underscore property if those become empty. This will often allow the input to be processed as a ValueSet.

This change is simpler than I expected, but this is largely due to the work on SUSHI to better handle various cases involving contained resources.

Testing Instructions:
Confirm that the new test and accompanying test fixture accurately reflect a ValueSet that references a contained system. Run a fshing trip with input that includes a ValueSet that references a contained system and confirm that the ValueSet is unchanged.

Related Issue:
Fixes #271.

When a ValueSet component references a contained system, the
valueset-system extension should be present at compose.system.extension.
When it is present, it is safe to throw it out, since SUSHI will add it
back in automatically. When it is removed, also remove the extension
list and containing underscore property if those become empty. This will
often allow the input to be processed as a ValueSet.
Copy link
Collaborator

@jafeltra jafeltra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change makes sense to me and works as described!

Copy link
Member

@cmoesel cmoesel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it!

@mint-thompson mint-thompson merged commit e6b0082 into master Nov 13, 2024
14 checks passed
@mint-thompson mint-thompson deleted the valueset-contained-codesystem branch November 13, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optimize ValueSets that refer to contained CodeSystems
3 participants