Skip to content
This repository was archived by the owner on Jan 12, 2021. It is now read-only.
This repository was archived by the owner on Jan 12, 2021. It is now read-only.

Wait For Condition Timer May Block Continuously #144

@mikeastarb

Description

@mikeastarb

https://github.com/FINRAOS/JTAF-ExtWebDriver/blob/master/src/main/java/org/finra/jtaf/ewd/timer/WaitForConditionTimer.java#L89

My team discovered today that, if the execute method of the callback blocks/hangs infinitely, this wait will also block/hang (waitForElementPresent ended up hanging on webdriver.findElement, which was waiting on IE to stop being busy). Our solution is to replace this logic with an ExecutorService and Future. This will still timeout if the passed in callable fails to return at all.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions