-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 1393 #1618
Fix 1393 #1618
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ |
I have read the CLA Document and I hereby sign the CLA |
I think I made a mistake with commits, I will resolve this as soon as possibile This pr is needed since the IOTagent use upsert to send measures, and this prevent to use the previosValue filed in subscription/notification when using LD |
I have read the CLA Document and I hereby sign the CLA |
Hello there and thank you so much for contributing. Apart from that, yesterday I noticed a problem with the docker files, a dependency package has disappeared and the build fails accordingly. |
The dockerfile problem has been solved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, very much appreciated!
(I fixed a few very minor style-guide related issues to make the PR pass the compliance tests) |
Proposed changes
Fix missing previous values for upsert/option=update call (#1393)
Types of changes
added previousValues(inEntityP, dbAttrsP); calls in src/lib/orionld/serviceRoutines/orionldPostBatchUpsert.cpp
added a functional test
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...