Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 1393 #1618

Merged
merged 4 commits into from
Jun 5, 2024
Merged

Fix 1393 #1618

merged 4 commits into from
Jun 5, 2024

Conversation

aquarta
Copy link

@aquarta aquarta commented Jun 5, 2024

Proposed changes

Fix missing previous values for upsert/option=update call (#1393)

Types of changes

added previousValues(inEntityP, dbAttrsP); calls in src/lib/orionld/serviceRoutines/orionldPostBatchUpsert.cpp
added a functional test

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING doc
  • I have signed the CLA
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

Copy link

github-actions bot commented Jun 5, 2024

CLA Assistant Lite bot All contributors have signed the CLA ✍️

@sgheppy
Copy link

sgheppy commented Jun 5, 2024

I have read the CLA Document and I hereby sign the CLA

@aquarta
Copy link
Author

aquarta commented Jun 5, 2024

I think I made a mistake with commits, I will resolve this as soon as possibile

This pr is needed since the IOTagent use upsert to send measures, and this prevent to use the previosValue filed in subscription/notification when using LD

@aquarta
Copy link
Author

aquarta commented Jun 5, 2024

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jun 5, 2024
@kzangeli
Copy link
Collaborator

kzangeli commented Jun 5, 2024

Hello there and thank you so much for contributing.
The feature "showChanges" in notifications was only partially implemented and this PR adds a little to it, so, that is very welcome!
However, I see a few of my changes in the diff - it seems you need to merge in the latest from the develop branch.

Apart from that, yesterday I noticed a problem with the docker files, a dependency package has disappeared and the build fails accordingly.
So, once this really runs, it will most probably fail, no need to worry.
A fix is on its way, a radical modification of the docker files. Hopefully today.

@kzangeli
Copy link
Collaborator

kzangeli commented Jun 5, 2024

The dockerfile problem has been solved.
I have two queued PRs I need to merge, now that I can.
After that, if this PR is still "as is", I'll use the github button to merge what's in develop.

Copy link
Collaborator

@kzangeli kzangeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, very much appreciated!

@kzangeli
Copy link
Collaborator

kzangeli commented Jun 5, 2024

(I fixed a few very minor style-guide related issues to make the PR pass the compliance tests)

@kzangeli kzangeli merged commit 722ba0c into FIWARE:develop Jun 5, 2024
8 of 9 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants