workaround #5
Closed
workaround #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pulledtim
commented
Oct 10, 2023
pulledtim
commented
- Simplified persistence to store configs of a service into a blob
- Workaround for faulty micronaut openapi codegen
pulledtim
added
the
minor
wistefan
requested changes
Oct 16, 2023
| @@ -1,26 +1,5 @@ | |||
| CREATE TABLE IF NOT EXISTS `service` ( | |||
| `id` varchar(255) NOT NULL PRIMARY KEY, | |||
| `default_oidc_scope` varchar(255) NOT NULL | |||
There was a problem hiding this comment.
Thats not how flyway works. You should add a new migration for the changes.
| private java.util.List<String> trustedIssuersLists; | ||
|
|
||
| // methods | ||
|
|
There was a problem hiding this comment.
Why dont you use the lombok methods?
| @@ -0,0 +1,142 @@ | |||
| package org.fiware.iam.ccs.model; | |||
|
|
|||
There was a problem hiding this comment.
Why do you add generated classes to the repo?
| @Join(value = "oidcScopes", type = Join.Type.LEFT_FETCH) | ||
| @Join(value = "oidcScopes.credentials", type = Join.Type.LEFT_FETCH) | ||
| @Join(value = "oidcScopes.credentials.trustedLists", type = Join.Type.LEFT_FETCH) | ||
| // @Join(value = "oidcScopes", type = Join.Type.LEFT_FETCH) |
|
Closing due to continuing on target branch |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.