Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RunPlanVector potential changes/enhancements #681

Closed
3 tasks
ptheywood opened this issue Sep 2, 2021 · 1 comment · Fixed by #983
Closed
3 tasks

RunPlanVector potential changes/enhancements #681

ptheywood opened this issue Sep 2, 2021 · 1 comment · Fixed by #983
Assignees

Comments

@ptheywood
Copy link
Member

ptheywood commented Sep 2, 2021

While testing / working with RunPlans and RunPlanVectors several potential improvements came up, but to avoid blocking bugfixes they're getting their own issue.

  • RunPlanVector::setPropertyUniformDistribution has a potentially misleading/ambiguos name, which is similar to setPropertyUniformRandom, which uses a Unform distribution. It should probably be renamed. It's more of a LERP imo, but there may be a more canonical name for this for similar use-cases.
  • operator== would be useful to compare RunPlan instances (and potentially RunPlanVectors) against one another. greatly simplifying some tests
  • RunPlanVector::at(size_t index). I.e. expose the vectors .at methods, which is operator[] with bounds checking.
@Robadob
Copy link
Member

Robadob commented Nov 2, 2022

RunPlanVector privately extends std::vector, so just need using statement added for at. There's already a bunch there.

@Robadob Robadob self-assigned this Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants