Ensemble, RunPlan(Vector) testing and RNG Changes #665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ptheywood
force-pushed
the
ensemble-test-and-rand-64
branch
3 times, most recently
from
13bef91 to
2ddb473
Compare
ptheywood
force-pushed
the
ensemble-test-and-rand-64
branch
4 times, most recently
from
fdee541 to
4f91030
Compare
|
Full test suite is passing under linux, including the ~ 40 new tests. Porting tests to python now |
This makes the full range of entropy available for curand, and upgrades host rng engines to the 64 bit version of mt19937
Provides access to the (initally) randomly generated seed used to generate new properties on the host. The returned value was only valid for properties generated since the seed was last set, so use is limited
These methods are supposed to return immutable configuraiton structs, but python/swig wrapping results in a mutable object.
This was using the result of unordered_map::find when it did not find the requested name, rather than the other way around.
Also fixes a number of exception strings
This matches default uses, and avoids the default value potentially throwing exceptions
These now match the std::array version
This occured before it could be disabled programatically
ptheywood
force-pushed
the
ensemble-test-and-rand-64
branch
from
4f91030 to
6ed9fa7
Compare
…UDAEnsemble Some python tests are skipped due to current implementation not allowing them
ptheywood
force-pushed
the
ensemble-test-and-rand-64
branch
from
6ed9fa7 to
aae80bd
Compare
Merged
|
Windows Tests: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests:
CUDAEnsembleRunPlanRunPlanVectorCUDAEnsembleRunPlanRunPlanVectorRequired fixes / changes
uint64_tuint64_t RunPlanVector::getRandomPropertySeedstd::device_randomif required.CUDAEnsemble::Configsuggests@see CUDAEnsemble::applyConfig() Should be called afterwards to apply changes, butapplyConfigis not a member of CUDAEnsemble.CUDAEnsemble::getConfigresult is mutable in python.Misc
Additional Changes
workflow_dispatchevents. Closes CI: Add workflow_dispatch windows test suite CI #683.Known issues (for the release notes)
operator+forRunPlanandRunPlanVectorare not currently working in pythonCUDAEnsemble::EnsembleConfig::devicesis not usable other than the command line in the swig interfaceCloses #656