Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Add workflow_dispatch windows test suite CI #683

Closed
ptheywood opened this issue Sep 2, 2021 · 0 comments · Fixed by #665
Closed

CI: Add workflow_dispatch windows test suite CI #683

ptheywood opened this issue Sep 2, 2021 · 0 comments · Fixed by #665

Comments

@ptheywood
Copy link
Member

Currently, the only time the test suite is built on windows (with warnings as errors enabled) is when doing a full draft release CI run, or making a draft release.
It is not enabled for regular per-push ci builds due to the time required.

As MSVC emits different warnings in some cases to gcc, it would be good to be able to run this (alone) manually.

The simplest option, with the lest duplication of workflow, will be to modify the condition of the build test step, so that if the regular windows ci was triggered by a workflow_dispatch to also build the test suite.

Alternatively a separate workflow could be created, to avoid running multiple CI jobs when one would be sufficient.

Or we could enable it on every build, but this would greatly slow down CI due to how long this takes to build when 2 cores/threads are available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant