Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swig Ignore Simulation::getSimulationConfig #689

Closed
ptheywood opened this issue Sep 7, 2021 · 0 comments · Fixed by #690
Closed

Swig Ignore Simulation::getSimulationConfig #689

ptheywood opened this issue Sep 7, 2021 · 0 comments · Fixed by #690
Labels

Comments

@ptheywood
Copy link
Member

ptheywood commented Sep 7, 2021

I missed this as part of #665, as I was expecteding getConfig not getSimulationConfig.

This should not be acecssible from python as it's marked const, but in python it's still mutable, so changes made are not applied to the underlying c++.

swig/python/flamegpu.i:362

// %ignore flamegpu::Simulation::getConfig; // This doesn't currently exist`

Needs uncommenting and adjusting.

Ideally add a test to make sure it's disabled to the appropraite test suite (CUDASimulation as Simulation is virtual so cannot be tested without an implementation)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant