Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle password visibility and fix wrong error message display in DeveloperSignup.jsx #308

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

thessakranendonk
Copy link

@thessakranendonk thessakranendonk commented Oct 28, 2022

Issue #307

  • Fix: Form reloads before showing error messages

  • Fix: No error message if username already exists

  • Fix: No error message if password does not match confirmation password

  • Fix: No error red colour changes for password or password confirmation

  • Fix: Error message for a short password displays error message at email input ("Email already exists")

  • Added: Password visibility toggle

  • Added: Submit button is disabled until input fields are populated

Screen Shot 2022-10-28 at 10 48 10 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant