Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: DbJson-Field with Set<?> in Extensions work now #90

Merged
merged 2 commits into from
May 25, 2023
Merged

Fix: DbJson-Field with Set<?> in Extensions work now #90

merged 2 commits into from
May 25, 2023

Conversation

AlexWagner
Copy link

No description provided.

rPraml
rPraml reviewed May 25, 2023
View reviewed changes
ebean-core/src/main/java/io/ebeaninternal/server/type/DefaultTypeManager.java
var req = new ScalarJsonRequest(jsonManager, dbType, docType, prop.getOwnerType(), prop.getMutationDetection(), prop.getName());
Class<?> type = prop.getOwnerType();
if (prop instanceof DeployBeanProperty) {
type = ((DeployBeanProperty) prop).getField().getDeclaringClass();
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Würde es Sinn machen, den Code in "getOwnerType" zu verlagern? Oder geht dann zu viel kaputt?

Copy link
Author

@AlexWagner AlexWagner May 25, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

grafik
wir haben das hier absichtlich auf den Typ von BeanDescriptor gesetzt, weils an anderen Stellen dann gekracht hat.
Nur an der einen Stelle passts jetzt halt nicht, weil er nach dem Field dann in der falschen Klasse sucht

@AlexWagner AlexWagner merged commit 4dad46e into master May 25, 2023
@AlexWagner AlexWagner deleted the fix-json-type-lookup-extension branch May 25, 2023 14:15
rPraml pushed a commit that referenced this pull request Aug 3, 2023
@AlexWagner @rPraml
Fix: DbJson-Field with Set<?> in Extensions work now (#90)
5aac915
rPraml pushed a commit that referenced this pull request Aug 3, 2023
@AlexWagner @rPraml
Fix: DbJson-Field with Set<?> in Extensions work now (#90)
ce637af
rPraml pushed a commit that referenced this pull request Aug 3, 2023
@AlexWagner @rPraml
Fix: DbJson-Field with Set<?> in Extensions work now (#90)
e9ccbb6
rPraml pushed a commit that referenced this pull request Aug 8, 2023
@AlexWagner @rPraml
Fix: DbJson-Field with Set<?> in Extensions work now (#90)
a71d23b
rPraml added a commit that referenced this pull request Aug 8, 2023
@rPraml
EntityExtension base code
8cfd2f8 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
123268d 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
e78e319 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
1718c60 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
12a11ce 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
b43c760 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
0d53e83 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
00ff426 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
11b3b1c 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
0e36dc0 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
c00f7a7 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
660772c 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
a811a23 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
rPraml added a commit that referenced this pull request Aug 9, 2023
@rPraml
EntityExtension base code
2980f12 
EntityExtension fixes

EntityExtension missing code

Fix: module-info

FIX Extensions with Inheritance (#82)

FIX: CheckInheritanceMapping correct place

Fix: DbJson-Field with Set<?> in Extensions work now (#90)

Make EntityExtensions stable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rPraml rPraml rPraml left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AlexWagner @rPraml