-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
packages/web/mainversion.php requires updating now for stable check #607
Comments
Thanks for bringing this to our attention and for giving the stable branch a go! We also should update that 'disclaimer' about switching between versions. Going between dev-branch and stable branch should be without issue. And yes the stable branch should be 1.5.10.48 in the version view. |
Should be fixed. Thanks for letting us know. |
* Should consistently use commits from master * Should push up same against dev-branch * Should update language files here for simpler handling * Should not output the found commands * Should fix version issue #607 * Should commit * update version number and .gitignore (for windows vscode dev envs)
Full fixed in new stable version 1.5.10.1565 This office website page for downloading the latest version is now updated dynamically too https://fogproject.org/download.php thanks to @mastacontrola. Also just want to link this over to #601 as it relates to the new automated release system. Thank you again for reporting this! @user-629782 |
Will try this over the weekend server maintenance window. Thank you both @darksidemilk and @mastacontrola for your fast response to this. |
After upgrading over the weekend to the new "stable" branch (git checkout stable from dev-branch) and check the FoG version information (wrench in GUI) I noticed that my version was still set to dev-branch and not stable. Looking at the mainversion.php file looks like the stablecheck variable is not being set; only the dev-check var is. I believe this is a result of the switch over to the stable branch and the check logic has not caught up yet.
FoG Version: 1.5.10.48 (stable but says dev-branch)
FoG Server: Rocky Linux 9.x (latest)
I also tried a fresh install of FoG "stale" branch (seeing the warning about going back to stable/master from dev-branch) but saw the same version information. I know this is not a big problem but just thought the devs should know. Congrats on the "stable" version and the idea of folding the dev-branch into it for more relevant releases. Good job!
P.S. Shouldn't the Stable version now be 1.5.10.48 and not 1.5.10 to mimic the "stable" release?
The text was updated successfully, but these errors were encountered: