Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gear detection #17

Closed
OrchardPerformance opened this issue Dec 29, 2022 · 12 comments
Closed

Gear detection #17

OrchardPerformance opened this issue Dec 29, 2022 · 12 comments
Labels
🐞 bug 🐞 Something isn't working
Milestone

Comments

@OrchardPerformance
Copy link
Member

Feature TS Notes:
Feature Status:
Known Problems:
Priority:
Suggested Fix:
Related Tickets:

Note -

image

@BeerMoneyMotorsports
Copy link
Contributor

Needs validation that it actually works. I dont think anyone has tested. Let me poke Alpha as he was supposed to.

@OSprey65
Copy link

I've tested gear detection on 09-01-2023 firmware and it doesn't work for me. The gearbox ratios are reading correct in my logs to what I've set the gear ratios to be (MX5 6sp with 3.909 diff ratio) but the desired and current gear parameters show 0. I've set the speed sensor up with all the correct data then changed the speed sensor gear ratio until the VSS was roughly right.
image
image

Corresponding tune and log:
https://rusefi.com/online/view.php?msq=1402

@OrchardPerformance
Copy link
Member Author

Looks like we can classify this broken then.

@OrchardPerformance OrchardPerformance added the 🐞 bug 🐞 Something isn't working label Feb 21, 2023
@OrchardPerformance OrchardPerformance transferred this issue from another repository Feb 23, 2023
@mck1117 mck1117 added this to the V1 milestone Feb 23, 2023
@mck1117
Copy link
Collaborator

mck1117 commented Mar 16, 2023

@OSprey65 can you try this again using latest firmware? I loaded your settings and it seems to decode properly for me. Try this firmware: https://github.com/FOME-Tech/fome-fw/actions/runs/4433131955

@OSprey65
Copy link

@mck1117 Can do, car is on stands currently so hopefully in the next week or so I can test it

@OSprey65
Copy link

OSprey65 commented Mar 17, 2023

@mck1117 Here's a log. The gear detection goes into 2nd for any speed over 5kph but doesn't work correctly despite my gearbox ratio log matching my gear ratio values. So I think it works but something isn't set up correctly for me. https://drive.google.com/file/d/1_lOVbRUpT9_798-QAueuMh2TzoC3EjdJ/view?usp=share_link
image
image

@mck1117
Copy link
Collaborator

mck1117 commented Mar 17, 2023

@OSprey65 can you drop your whole msq in here? I'm unable to repro this issue, so our best shot is to reproduce your whole ECU locally for me.

@OSprey65
Copy link

OSprey65 commented Mar 17, 2023

@mck1117 https://drive.google.com/file/d/1gyGpikEEl3SGTw0zgMIvjp8hD_QC2pRo/view?usp=share_link
Do you think perhaps the filter parameter needs to be lower for it to work propperly? I don't see why it's not working if I have the correct gear ratios put in and it's detecting the correct ratios.
Here's an extract from the log where it jumps between 0/2 gear when the speed drops below 7kph:
image

@OSprey65
Copy link

@mck1117 Ok so I've just learnt today a little know fact that the 10AE MX5 in AU actually has a 3.6 diff not a 3.9. So few people know this that there was a massive debate about it until someone posted an AU spec sheet. When I get the chance, I'm going to reconfigure my final drive and speed sensor for a 3.6 and see how if that helps.

@BeerMoneyMotorsports
Copy link
Contributor

Easy to confirm if the car is in the air. How many rpm at 70mph?

@OSprey65
Copy link

@mck1117 see here for gear detection log in TS

@mck1117
Copy link
Collaborator

mck1117 commented May 2, 2023

Gear detection is FIXED #86

@mck1117 mck1117 closed this as completed May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug 🐞 Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants