Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gear detect doesn't work until a config change happens #86

Open
mck1117 opened this issue Apr 20, 2023 · 1 comment
Open

gear detect doesn't work until a config change happens #86

mck1117 opened this issue Apr 20, 2023 · 1 comment
Labels
🐞 bug 🐞 Something isn't working

Comments

@mck1117
Copy link
Collaborator

mck1117 commented Apr 20, 2023 •
edited
Loading

We need to init at init, not only at reinit

GearDetector::onConfigurationChange needs to call at startup
@mck1117 mck1117 changed the title gear detect doesn't work if gears past your highest gear aren't set gear detect doesn't work until a config change happens Apr 22, 2023
mck1117 added a commit that referenced this issue Apr 22, 2023
@mck1117
BODGE fix gear detector #86
cb49ef7
@mck1117 mck1117 mentioned this issue Apr 28, 2023
Open
@mck1117 mck1117 added the 🐞 bug 🐞 Something isn't working label May 2, 2023
@mck1117
Copy link
Collaborator Author

mck1117 commented May 2, 2023

This is currently bodged to work, but needs #87 to be "right"

@mck1117 mck1117 mentioned this issue May 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐞 bug 🐞 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mck1117