Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Knock Control : Usability of max knock retard table #192

Closed
OrchardPerformance opened this issue Jul 17, 2023 · 3 comments
Closed

Knock Control : Usability of max knock retard table #192

OrchardPerformance opened this issue Jul 17, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@OrchardPerformance
Copy link
Member

Current max allowed knock retard table is just a table of degrees, requiring a user to subtract this from their ignition table to check if they are going to be past TDC/too retarded.

We should make this a table of degrees relative to TDC, so a user only has to enter their desired worst case ignition timing.

Current method will work, just requires more calculation hence the enhancement tag.

image

@OrchardPerformance OrchardPerformance added the enhancement New feature or request label Jul 17, 2023
@OrchardPerformance OrchardPerformance changed the title Knock Control : Usability of max allowed retard table Knock Control : Usability of max knock retard table Jul 17, 2023
@mck1117
Copy link
Collaborator

mck1117 commented Sep 15, 2023

Should this change if we still have a global min/max timing setting?

@OrchardPerformance
Copy link
Member Author

Nahh, it's a pretty application specific requirement, we are trying to prevent insane egts as well as firing past tdc on wasted spark so it's quite load/rpm dependent.

@OrchardPerformance
Copy link
Member Author

Played about with this the other day, needs a tool tip but that's a minor thing.
Will create a tool tip ticket when we are sure it all works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants