Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Global min/max allowed ignition timing #211

Closed
mck1117 opened this issue Jul 21, 2023 · 2 comments
Closed

Global min/max allowed ignition timing #211

mck1117 opened this issue Jul 21, 2023 · 2 comments

Comments

@mck1117
Copy link
Collaborator

mck1117 commented Jul 21, 2023

Add parameters for min/max allowed timing. The concern is that the base table plus various adders could end up stacking in ways that result in timing unsafe for your engine (for example, wasted spark).
@mck1117
Copy link
Collaborator Author

mck1117 commented Jul 21, 2023

related to #192

@mck1117 mck1117 mentioned this issue Jul 21, 2023
Merged
@mck1117
Copy link
Collaborator Author

mck1117 commented Jul 25, 2023

done!

@mck1117 mck1117 closed this as completed Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mck1117