Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bench test improvements #219

Closed
mck1117 opened this issue Jul 31, 2023 · 5 comments
Closed

Bench test improvements #219

mck1117 opened this issue Jul 31, 2023 · 5 comments

Comments

@mck1117
Copy link
Collaborator

mck1117 commented Jul 31, 2023

  • add button for "abort test" (the scenario is that your injector test bucket is about to overflow or you started a longer test than you want)
  • increase maximum count
  • independent parameters for fuel/spark/etc
@125jdavis
Copy link
Contributor

  • Fuel pressure gauge in "Injector test" window in TS would be useful.
  • Add "Fuel pump on" button in injector test window so that fuel pump can be kept on via ECU during injector tests.

@125jdavis
Copy link
Contributor

  • Injector test window does not specify which injector(s) are being tested. Do we want to actuate all injectors? I'm not sure if I have an opinion yet.
  • Also, there is no "test" button, only "Burn".

@mck1117
Copy link
Collaborator Author

mck1117 commented Aug 3, 2023

Injector test window

Which injector test window? Screenshot?

mck1117 added a commit that referenced this issue Aug 3, 2023
@mck1117
allow more bench test count #219
cc5c337
@125jdavis
Copy link
Contributor

image

mck1117 added a commit that referenced this issue Aug 4, 2023
@mck1117
bench test cancellation #219
2f7f4d8
mck1117 added a commit that referenced this issue Aug 4, 2023
@mck1117
bench test has no need for pin AND pin #219
8af1d7c
mck1117 added a commit that referenced this issue Aug 5, 2023
@mck1117
typo #219
631a166
mck1117 added a commit that referenced this issue Aug 6, 2023
@mck1117
rearrange bench test UI #219
a2f1966
mck1117 added a commit that referenced this issue Aug 6, 2023
@mck1117
bench test buttons for fuel pump on/off #219
f7bf589
mck1117 added a commit that referenced this issue Aug 6, 2023
@mck1117
16 bit bench test counter, compactify output bits #219
89815e7
@mck1117
Copy link
Collaborator Author

mck1117 commented Aug 10, 2023

Used the new UI to flow test my fuel injectors, worked great!

@mck1117 mck1117 mentioned this issue Aug 19, 2023
Merged
@mck1117 mck1117 closed this as completed Aug 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mck1117 @125jdavis