Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix table in section "Standard OBD fault codes not used by FOME" #134

Merged
merged 2 commits into from
Aug 15, 2023

Conversation

mi-hol
Copy link
Contributor

@mi-hol mi-hol commented Jul 24, 2023

No description provided.

@mi-hol
Copy link
Contributor Author

mi-hol commented Aug 2, 2023

@karniv00l @OrchardPerformance for my PRs that don't change content (like this one), would it be ok for Piotr to decide about merging them?

@nmschulte
Copy link
Contributor

nmschulte commented Aug 10, 2023

It looks like this change needs applied to all of the rows of this table.

@mi-hol: mi-hol#2

@mi-hol
Copy link
Contributor Author

mi-hol commented Aug 10, 2023

It looks like this change needs applied to all of the rows of this table.

Right, I should have elaborated that I'm hunting down the reason for a difference of how tables are displayed in GH versus Docusaurus created webpage (see below).

It's not clear yet if the fix will work (due to lack of building a temp wiki website), therefore I limited my effort to bare minimum but plan to complete the full doc after the approach is confirmed to work.

Does that approach make sense or did I miss an obvious ability to test Docusaurus ?

GH table:
image

Docusaurus table:
image

@mi-hol
Copy link
Contributor Author

mi-hol commented Aug 10, 2023

underlying issue captured in #135

@nmschulte
Copy link
Contributor

Does that approach make sense or did I miss an obvious ability to test Docusaurus ?

I'm not certain it's what you're looking for, but I test Docusaurus by simply:

 # in wiki repo root
npm ci # install Node dependencies
npm run start # start Docusaurus [live] build, hosted at: http://localhost:3000/

@mi-hol
Copy link
Contributor Author

mi-hol commented Aug 10, 2023

I have now fixed all tables so they display correctly in GH and Docusaurus

@mi-hol
Copy link
Contributor Author

mi-hol commented Aug 10, 2023

test Docusaurus by simply

thanks for the hint "how to test a page in Docusaurus".
I've noticed now that a similar hint is (from my perspective hidden) under the title start-your-site

@mi-hol mi-hol closed this Aug 10, 2023
@mi-hol mi-hol reopened this Aug 10, 2023
@OrchardPerformance OrchardPerformance merged commit e2dec22 into FOME-Tech:master Aug 15, 2023
8 checks passed
@mi-hol mi-hol deleted the patch-2 branch September 11, 2023 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants