Skip to content
This repository has been archived by the owner on Mar 14, 2023. It is now read-only.

find_updates: return in ALL the appropriate failure cases #10

Merged
merged 1 commit into from
Apr 3, 2021
Merged

find_updates: return in ALL the appropriate failure cases #10

merged 1 commit into from
Apr 3, 2021

Conversation

RhinosF1
Copy link

@RhinosF1 RhinosF1 commented Apr 3, 2021 •
edited
Loading

Even if there haven't been enough check failures to trigger a warning to
Sopel's owner, it still needs to skip trying to print the info about
whatever new release is available because that variable doesn't exist.

Fixes sopel-irc#2051.

Missed in sopel-irc#1779 / 951fcca, oops.

Description

What does this do? What problem does it solve? Does it resolve any GitHub issues?

Checklist

  • I have read CONTRIBUTING.md
  • I can and do license this contribution under the EFLv2
  • No issues are reported by make qa (runs make quality and make test)
  • I have tested the functionality of the things this change touches

@dgw
find_updates: return in ALL the appropriate failure cases
8dbce96 
Even if there haven't been enough check failures to trigger a warning to
Sopel's owner, it still needs to skip trying to print the `info` about
whatever new release is available because that variable doesn't exist.

Fixes #2051.

Missed in #1779 / 951fcca, oops.
@RhinosF1 RhinosF1 merged commit 00e05fc into FOSSBots:sync-dev Apr 3, 2021
@dgw dgw deleted the find_updates-UnboundLocalError branch April 30, 2021 02:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RhinosF1 @dgw