jekyll page #69
jekyll page #69
Conversation
kennedy
added
T: contributor experience
| - jekyll-paginate | ||
| - jekyll-readme-index | ||
| - jekyll-titles-from-headings | ||
| - jekyll-relative-links |
There was a problem hiding this comment.
These plugins are enabled by default if using github pages to generate
| @@ -6,6 +6,6 @@ major: Game Design and Development | |||
| graduation: 2015 | |||
| handle: ajman1101 | |||
| forges: | |||
| GitHub: http://github.com/ajman1101 | |||
| GitHub: https://github.com/ajman1101 | |||
There was a problem hiding this comment.
I've went through and updated all urls to https
| @@ -1,6 +1,6 @@ | |||
| --- | |||
| name: Ian Gilbert | |||
| blog: n-g.biz | |||
| blog: http://n-g.biz | |||
There was a problem hiding this comment.
all urls must append https:// or else it would become a relative href path
| - faculty.html | ||
| - student.html | ||
| - mentor.html | ||
| - alum.html |
There was a problem hiding this comment.
This defines the navigation bar. Each of these pages must have a title frontmatter
_config.yaml
Outdated
| github_username: FOSSRIT | ||
|
|
||
| minima: | ||
| skin: solarized-dark |
There was a problem hiding this comment.
ignore... version 2.5.1 does not have skins.
There was a problem hiding this comment.
@kennedy Any reason to leave it in the config at all?
There was a problem hiding this comment.
Pure laziness. haha. ill remove it
| @@ -0,0 +1,53 @@ | |||
| {% assign page_category = (include.content | remove: ".html") %} | |||
| <div class="profile_list"> | |||
| {% for category_pair in site.data %} | |||
There was a problem hiding this comment.
Due to the file structure of _data/..., traverse through each person's profile was non-standard.
| {% endfor %} | ||
| </ul> | ||
| </li> | ||
| {% endif %} |
There was a problem hiding this comment.
Rendered design was based off templates.html from the project. There is room for improvement
There was a problem hiding this comment.
This is definitely something we can solicit some more participation from folks on. Not a problem! 👍
| @@ -0,0 +1,16 @@ | |||
| --- | |||
There was a problem hiding this comment.
This overrides the theme's main.scss.
I turned the profiles into flexbox.
There was a problem hiding this comment.
Any specific reason for flexbox? I'm not picky about it, just curious since web dev is not my strong suit.
There was a problem hiding this comment.
There were a few ways of doing this, but utilizing new browser standard technologies reduces the need for third party javascript. After some quick reading on how to accomplish the desired responsive behavior, flexbox keeps coming up, so I felt it was a good idea to learn the basics of it.
There was a problem hiding this comment.
@kennedy Uhhh, this is totally awesome 😍 It is super exciting to see this come to life. Thanks for working on this!
I left a few comments and questions, but there was only one thing that actually needs changes. I think a GitLab URL was sliced off by mistake on one profile. Otherwise, I'm ready to merge this. I definitely didn't look super close at the HTML/CSS, but I think it's also fine to get this merged and we can iterate smaller PRs on the site going forward.
Also thanks for triaging the metadata on this, I appreciate that. 👍
_data/alum/axk4545.yml
Outdated
| @@ -8,5 +8,5 @@ graduation: 2018 | |||
| handle: axk4545 | |||
| forges: | |||
| GitHub: https://github.com/axk4545/ | |||
| GitLab: https://gitlab.com/axk4545/ | |||
| GitLab: axk4545/ | |||
There was a problem hiding this comment.
I think you might have sliced off the gitlab.com part of this URL by mistake?
_config.yaml
Outdated
| github_username: FOSSRIT | ||
|
|
||
| minima: | ||
| skin: solarized-dark |
There was a problem hiding this comment.
@kennedy Any reason to leave it in the config at all?
| {% endfor %} | ||
| </ul> | ||
| </li> | ||
| {% endif %} |
There was a problem hiding this comment.
This is definitely something we can solicit some more participation from folks on. Not a problem! 👍
| @@ -0,0 +1,16 @@ | |||
| --- | |||
There was a problem hiding this comment.
Any specific reason for flexbox? I'm not picky about it, just curious since web dev is not my strong suit.
| layout: home | ||
| title: Student | ||
| --- | ||
| {% include profiles.html content=page.name %} |
There was a problem hiding this comment.
Nice and simple. Also leaves room to iterate future categories on here too, for example if we want to add a "Friends" section for folks not formally affiliated to RIT but who hang around the FOSS@RIT community!
There was a problem hiding this comment.
I didnt think of that, but yes, this design would support that
jwflory
removed
T: contributor experience
…orted in this version
I am using the jekyll minima theme (v2.5.1). It is a bit dated but it is still clean and easy to work with. I took into consideration the navigation feature.
here are the screenshots of the faculty and mentor page, but the student, alum, and home page works