Cleaned up the SConstruct files and added them to the 'make lint' target. #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed these warnings: * line too long * fixme * imported by unused * f-string is missing placeholders
apio/resources/ecp5/SConstruct:115:12: F523 '...'.format(...) has unused arguments at position(s): 1 apio/resources/gowin/SConstruct:112:12: F523 '...'.format(...) has unused arguments at position(s): 1, 2
…errors where fixed and/or supressed and the SConstruct files where added to the 'make lint' target. E0611 and E1101 are due to the magic that scons does when running SConstruct, for example, improting methods and variables implicitly such that pylint is not aware of it. A partial workaround is to refer to them through the env object, for example 'env.GLOB()' instead of 'GLOB()' but it's not clear yet what is the best approach.
…o the common scons_util.py library. Behavior should be identical.
…identifies also verilog import directives.
…attribure of he build target conditional on verbose all. An no change apio build now gives a nice "scons: `build' is up to date." message.
…verilator config file hardware.vlt to be sent to the verilog source scanner.
… for testing. This is a straight verilog project but can replaced later with a IceStudion version.
Obijuan
approved these changes
Sep 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SConstruct files are now also subject to black, flake8, and pylint, similar to the apio .py files.