Assorted cleanups #439
Merged
Assorted cleanups #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ng to a class with named fields. Behavior stay the same.
…d and tweaked it for readability. Behavior should not change.
1. Moved the filter functionality from scons.py to a new file scons_filter.py. 2. Merged the handling of stdout and stderr lines to a single method. 3. Added the concept of range detector which identify a range of lines of interest. 4. Implemented a range detector for nextpnr verbose log. 5. Added a TODO to implement similar range detectors for fumo, iceprog, tinyprog. 6. Now removing the 'Info:' prefix of nextpnr verbose lines and coloring the speed lines. 7. Now preserving blank lines for better readability of nextpnr and yosys verbose logs. NOTE: I could not test the filter functionality for fumo, tinyprog and iceprog, for the lack of compatible hardware.
…They seems to appear only for ice40 architectures and for that the recomanded source of timing is 'apio time'.
…s. An error message about the missing implemention functionality is not printed eariler in the chain.
…ng: No .lpf constraints file, assuming '.lpf'] (should be main.lpf) if an lpf file is not available. Now apio clean passes the top_module variable to the scons.
…--top-module option.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assorted cleanups. The details descriptions are in the commits.