added roomClients method #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
returns rooms the socket is in returns all rooms if no socket id is passed in
|
I am not really sure about the optional first param. redis-adapter doesn't support this. |
|
I think it should be required, without it the function call wouldn't make sense. |
|
Agreed about the name change I just named it roomClients because it was called that in 0.9.x. clientRooms makes more sense. A way to get all rooms in a hash would be useful as well but I made a separate issue for that on main socket.io repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
returns rooms the socket is in
returns all rooms if no socket id is passed in