Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse dir #63

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Parse dir #63

merged 2 commits into from
Mar 23, 2021

Conversation

jessepisel
Copy link
Contributor

updated parse_directory so that capitalization in the file extension does not matter.

The parse_directory method was having issues with capitalization in the LAS file extensions. I changed the requirement from .las as a string to a tuple of (".LAS", ".las"). This appears to fix this issue at this time. All local tests are passing
Fixes #60

Reminders

  • Run black . to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • If adding new functionality, add an example to the docstring, gallery, and/or tutorials.

updated parse_directory so that capitalization in the file extension does not matter.
added test to ensure that the alias dictionary has keys when parsing a directory
@codecov
Copy link

codecov bot commented Mar 23, 2021

Codecov Report

Merging #63 (ff77412) into master (cd94f87) will decrease coverage by 0.08%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
- Coverage   83.26%   83.18%   -0.09%     
==========================================
  Files          12       12              
  Lines        1655     1659       +4     
==========================================
+ Hits         1378     1380       +2     
- Misses        277      279       +2     
Impacted Files Coverage Δ
alaska/keyword_tree.py 99.69% <100.00%> (ø)
alaska/tests/test_parser.py 100.00% <100.00%> (ø)
alaska/get_data_path.py 77.77% <0.00%> (-22.23%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cd94f87...ff77412. Read the comment docs.

@jessepisel jessepisel merged commit 52b98d7 into master Mar 23, 2021
@jessepisel jessepisel deleted the parse_dir branch March 23, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Parse Directory method returns empty dictionary
1 participant