-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bgp_labeled_safi doesn't cover all labelled safi types #471
Labels
Comments
This will probably be addressed by bug #473 |
louberger
added a commit
to LabNConsulting/frr
that referenced
this issue
May 13, 2017
Signed-off-by: Lou Berger <lberger@labn.net>
I think this is addressed by recent PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
bgp_labeled_safi should wither just cover the UNICAST case or should include EVPN. Usage is inconsistent as sometimes code post check assumes UNICAST and other times then makes explicit checks for EVPN. This should be make consistent, i.e., include all safit types that support labels and calling code needs to be modified as appropriate.
static inline int
bgp_labeled_safi (safi_t safi)
{
if ((safi == SAFI_LABELED_UNICAST) || (safi == SAFI_MPLS_VPN))
return 1;
return 0;
}
The text was updated successfully, but these errors were encountered: