Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgp_labeled_safi doesn't cover all labelled safi types #471

Closed
louberger opened this issue May 5, 2017 · 2 comments
Closed

bgp_labeled_safi doesn't cover all labelled safi types #471

louberger opened this issue May 5, 2017 · 2 comments
Labels

Comments

@louberger
Copy link
Member

bgp_labeled_safi should wither just cover the UNICAST case or should include EVPN. Usage is inconsistent as sometimes code post check assumes UNICAST and other times then makes explicit checks for EVPN. This should be make consistent, i.e., include all safit types that support labels and calling code needs to be modified as appropriate.

static inline int
bgp_labeled_safi (safi_t safi)
{
if ((safi == SAFI_LABELED_UNICAST) || (safi == SAFI_MPLS_VPN))
return 1;
return 0;
}

@donaldsharp donaldsharp added the bug label May 9, 2017
@donaldsharp
Copy link
Member

This will probably be addressed by bug #473

louberger added a commit to LabNConsulting/frr that referenced this issue May 13, 2017
Signed-off-by: Lou Berger <lberger@labn.net>
@louberger
Copy link
Member Author

I think this is addressed by recent PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants