Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Useful Sysctl Settings recommendations. #1193

Merged
merged 1 commit into from
Sep 19, 2017

Conversation

ericpulvino
Copy link
Contributor

As part of lessons learned from #1177 adding a useful Sysctl section to docs.

@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 18, 2017

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1193 1ec4697
Date 09/18/2017
Start 12:00:09
Finish 12:23:29
Run-Time 23:20
Total 1808
Pass 1808
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2017-09-18-12:00:09.txt
Log autoscript-2017-09-18-12:00:43.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-1698/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 1193, comparing to Git base SHA a7dd519

No Changes in Static Analysis warnings compared to base

79 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-1698/artifact/shared/static_analysis/index.html

@Jafaral
Copy link
Member

Jafaral commented Sep 19, 2017

I would like to have this in, it is just a recommendation list serving as a good reference. We can always update it.

Anyone objecting putting this in?

@donaldsharp
Copy link
Member

agreed @Jafaral let's get this in and we can update documentation as we go.

@Jafaral Jafaral merged commit 74fae3f into FRRouting:master Sep 19, 2017
@Jafaral
Copy link
Member

Jafaral commented Sep 19, 2017

@donaldsharp it is in, we should mention this somewhere in the documentation to let the users at least look at it even if they don't want to use it as-is.

qlyoung pushed a commit to qlyoung/frr that referenced this pull request Nov 6, 2017
…ions

Adding Useful Sysctl Settings recommendations.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants