Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pimd: Do not complain if re-joining an IGMP group #1194

Merged
merged 1 commit into from
Sep 19, 2017
Merged

pimd: Do not complain if re-joining an IGMP group #1194

merged 1 commit into from
Sep 19, 2017

Conversation

dwalton76
Copy link
Contributor

Signed-off-by: Daniel Walton dwalton@cumulusnetworks.com

If you cut-n-paste an existing "ip igmp join 233.200.0.0 0.0.0.0"
command under an interface we should not return an error.

Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com>

If you cut-n-paste an existing "ip igmp join 233.200.0.0 0.0.0.0"
command under an interface we should not return an error.
@LabN-CI
Copy link
Collaborator

LabN-CI commented Sep 18, 2017

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1194 53d829f
Date 09/18/2017
Start 12:25:07
Finish 12:48:27
Run-Time 23:20
Total 1808
Pass 1808
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2017-09-18-12:25:07.txt
Log autoscript-2017-09-18-12:25:41.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-1699/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.


CLANG Static Analyzer Summary

  • Github Pull Request 1194, comparing to Git base SHA a7dd519

No Changes in Static Analysis warnings compared to base

79 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-1699/artifact/shared/static_analysis/index.html

@Jafaral
Copy link
Member

Jafaral commented Sep 18, 2017

What about we keep the warning but return ferr_ok()?

Keep the warning: something along the lines of "already joined group such and such"

@dwalton76
Copy link
Contributor Author

We do not display a warning for other commands when they are reconfigured though...this one command is very inconsistent from the rest of the cli experience.

@Jafaral Jafaral merged commit 6a989fc into FRRouting:master Sep 19, 2017
qlyoung pushed a commit to qlyoung/frr that referenced this pull request Nov 6, 2017
…-group

pimd: Do not complain if re-joining an IGMP group
@dwalton76 dwalton76 deleted the igmp-rejoin-existing-group branch January 17, 2018 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants