Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi chunk trial #14180

Closed
wants to merge 6 commits into from
Closed

Multi chunk trial #14180

wants to merge 6 commits into from

Conversation

pguibert6WIND
Copy link
Member

This is a continuation work from #9932.
Work has stopped, I don't know why.
I don't say it is definitive, it is still a draft.
let see first if there is no regression..

Drumato and others added 6 commits August 11, 2023 12:27
@Drumato @pguibert6WIND
zebra: step1 separate locator prefix into multi chunks with 4-bits le…
44e1ae9 
…ngth

Signed-off-by: Yamato Sugawara <yamato.sugawara@linecorp.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
@Drumato @pguibert6WIND
zebra: step2 chunk pool expansion and move locator_add to the proper cmd
41c36a4 
Signed-off-by: Yamato Sugawara <yamato.sugawara@linecorp.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
@Drumato @pguibert6WIND
zebra: avoiding build error on bsd by using s6_addr16 macro
6e587fb 
Signed-off-by: Yamato Sugawara <yamato.sugawara@linecorp.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
@Drumato @pguibert6WIND
zebra: avoiding build error on *bsd again
3b37df9 
Signed-off-by: Yamato Sugawara <yamato.sugawara@linecorp.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
@pguibert6WIND
bgpd: add json output for show bgp segment-routing srv6
dac9ba2 
Add json support for 'show bgp segment-routing srv6' command.

Signed-off-by: Yamato Sugawara <yamato.sugawara@linecorp.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
@Drumato @pguibert6WIND
topotests: add srv6_locator_chunks test for testing multi chunks
d80110a 
This test checks sharing locator sids between sharpd and bgpd.

Signed-off-by: Yamato Sugawara <yamato.sugawara@linecorp.com>
Signed-off-by: Philippe Guibert <philippe.guibert@6wind.com>
@pguibert6WIND
Copy link
Member Author

@slankdev ,@Drumato, you are welcome to share your thought whether or not this piece of code should be kept.

@pguibert6WIND pguibert6WIND marked this pull request as draft August 11, 2023 10:35
@Drumato
Copy link
Contributor

Drumato commented Aug 11, 2023

@pguibert6WIND thanks to continue my PR!
#9932 aimed to achieve the multi-chunk task. I confirmed all topotests about SRv6 Manager with #9932. But maybe some conditions were not satisfied so #9932 was not merged.

share your thought whether or not this piece of code should be kept.

If you think #9932 is useful for your task, I'm ok to keep #9932.
if you don't, erase all code and please write alternative code to implement!

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

Test incomplete. See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/

This is a comment from an automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source / Pull Request: Successful

Building Stage: Successful

Basic Tests: Incomplete

Topotests Ubuntu 18.04 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18AMD64-13437/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO6U18AMD64/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO6U18AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 9: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 9: No useful log found
Addresssanitizer topotests part 4: Incomplete (check logs for details)
Topotests debian 10 amd64 part 9: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO9DEB10AMD64-13437/test

Topology Tests failed for Topotests debian 10 amd64 part 9
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO9DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 9: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO9DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 0: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO0U18ARM8/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18ARM8-13437/test

Topology Tests failed for Topotests Ubuntu 18.04 arm8 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO0U18ARM8/TopotestLogs/log_topotests.txt

Topotests debian 10 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0DEB10AMD64-13437/test

Topology Tests failed for Topotests debian 10 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO0DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO0DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 i386 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6U18I386-13437/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO6U18I386/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 i386 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO6U18I386/TopotestDetails/

Topotests debian 10 amd64 part 6: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO6DEB10AMD64-13437/test

Topology Tests failed for Topotests debian 10 amd64 part 6
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO6DEB10AMD64/TopotestLogs/log_topotests.txt
Topotests debian 10 amd64 part 6: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO6DEB10AMD64/TopotestDetails/

Topotests Ubuntu 18.04 amd64 part 0: Failed (click for details)

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPOU1804-13437/test

Topology Tests failed for Topotests Ubuntu 18.04 amd64 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPOU1804/TopotestLogs/log_topotests.txt
Topotests Ubuntu 18.04 amd64 part 0: Unknown Log
URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPOU1804/TopotestDetails/

Topotests Ubuntu 18.04 arm8 part 6: Failed (click for details) Topotests Ubuntu 18.04 arm8 part 6: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO6U18ARM8/TopotestDetails/ Topotests Ubuntu 18.04 arm8 part 6: No useful log found
Topotests Ubuntu 18.04 i386 part 0: Failed (click for details) Topotests Ubuntu 18.04 i386 part 0: Unknown Log URL: https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO0U18I386/TopotestDetails/

Topology Test Results are at https://ci1.netdef.org/browse/FRR-PULLREQ2-TOPO0U18I386-13437/test

Topology Tests failed for Topotests Ubuntu 18.04 i386 part 0
see full log at https://ci1.netdef.org/browse/FRR-PULLREQ2-13437/artifact/TOPO0U18I386/TopotestLogs/log_topotests.txt

Successful on other platforms/tests
  • Topotests Ubuntu 18.04 amd64 part 2
  • Topotests Ubuntu 18.04 i386 part 8
  • Topotests Ubuntu 18.04 i386 part 3
  • Topotests debian 10 amd64 part 8
  • Addresssanitizer topotests part 0
  • Topotests debian 10 amd64 part 3
  • Topotests Ubuntu 18.04 arm8 part 4
  • Topotests Ubuntu 18.04 arm8 part 3
  • Debian 9 deb pkg check
  • Addresssanitizer topotests part 1
  • Topotests Ubuntu 18.04 i386 part 4
  • Topotests debian 10 amd64 part 4
  • Topotests debian 10 amd64 part 2
  • Addresssanitizer topotests part 9
  • Topotests Ubuntu 18.04 amd64 part 9
  • Topotests Ubuntu 18.04 i386 part 9
  • Topotests Ubuntu 18.04 arm8 part 7
  • Topotests Ubuntu 18.04 amd64 part 8
  • Topotests Ubuntu 18.04 arm8 part 2
  • Static analyzer (clang)
  • Addresssanitizer topotests part 7
  • Ubuntu 20.04 deb pkg check
  • Topotests Ubuntu 18.04 amd64 part 5
  • Debian 10 deb pkg check
  • Topotests debian 10 amd64 part 1
  • Topotests Ubuntu 18.04 arm8 part 5
  • Addresssanitizer topotests part 5
  • Topotests Ubuntu 18.04 i386 part 1
  • Topotests Ubuntu 18.04 arm8 part 1
  • Addresssanitizer topotests part 3
  • Topotests Ubuntu 18.04 amd64 part 7
  • Topotests Ubuntu 18.04 i386 part 5
  • Addresssanitizer topotests part 2
  • Topotests debian 10 amd64 part 5
  • Topotests Ubuntu 18.04 amd64 part 4
  • CentOS 7 rpm pkg check
  • Topotests debian 10 amd64 part 7
  • Topotests Ubuntu 18.04 amd64 part 3
  • Addresssanitizer topotests part 8
  • Topotests Ubuntu 18.04 i386 part 7
  • Topotests Ubuntu 18.04 i386 part 2
  • Topotests Ubuntu 18.04 arm8 part 8
  • Ubuntu 18.04 deb pkg check
  • Addresssanitizer topotests part 6
  • Topotests Ubuntu 18.04 amd64 part 1

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 2, 2024

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@pguibert6WIND
Copy link
Member Author

will be replaced with #15604

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bgp conflicts master size/XXL zebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pguibert6WIND @Drumato @NetDEF-CI