Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bgpd: convert network statements from DEFUN to DEFPY #1572

Merged
merged 1 commit into from
Jan 2, 2018
Merged

bgpd: convert network statements from DEFUN to DEFPY #1572

merged 1 commit into from
Jan 2, 2018

Conversation

dslicenc
Copy link
Member

Problems reported with inconsistent use of parameters for bgp network
statements. Converted 12 DEFUNs to 2 DEFPY statements, making the
parameter use consistent with the exception of keeping the "backdoor"
keyword ipv4 only. Also verified that if a route-map or label-index
is specified in the "no" case it matches what had been previously
defined. Manual testing looks good and bgp-smoke passed with no new
failures except test changes to account for new consistency.

Ticket: CM-16860
Signed-off-by: Don Slice dslice@cumulusnetworks.com
Reviewed-by: CCR-7056

@dslicenc
bgpd: convert network statements from DEFUN to DEFPY
e2a86ad 
Problems reported with inconsistent use of parameters for bgp network
statements.  Converted 12 DEFUNs to 2 DEFPY statements, making the
parameter use consistent with the exception of keeping the "backdoor"
keywork ipv4 only.  Also verified that if a route-map or label-index
is specified in the "no" case it matches what had been previously
defined. Manual testing looks good and bgp-smoke will be performed
before pushing.

Ticket: CM-16860
Signed-off-by: Don Slice <dslice@cumulusnetworks.com>
Reviewed-by: CCR-7056
@LabN-CI
Copy link
Collaborator

LabN-CI commented Dec 21, 2017

💚 Basic BGPD CI results: SUCCESS, 0 tests failed

Results table
_ _
Result SUCCESS git merge/1572 e2a86ad
Date 12/21/2017
Start 14:20:10
Finish 14:43:02
Run-Time 22:52
Total 1808
Pass 1808
Fail 0
Valgrind-Errors 0
Valgrind-Loss 0
Details vncregress-2017-12-21-14:20:10.txt
Log autoscript-2017-12-21-14:20:55.log.bz2

For details, please contact louberger

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: FAILED

See below for issues.
CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2218/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

Get source and apply patch from patchwork: Successful

Building Stage: Successful

Basic Tests: Failed

IPv4 ldp protocol on Ubuntu 16.04: Successful
Ubuntu 14.04 deb pkg check: Successful
Addresssanitizer topotest: Successful
Debian 8 deb pkg check: Successful
Fedora 24 rpm pkg check: Successful
IPv4 protocols on Ubuntu 14.04: Successful
Debian 9 deb pkg check: Successful
CentOS 7 rpm pkg check: Successful
Ubuntu 12.04 deb pkg check: Successful
Static analyzer (clang): Successful
IPv6 protocols on Ubuntu 14.04: Successful
CentOS 6 rpm pkg check: Successful
Ubuntu 16.04 deb pkg check: Successful

Topology tests on Ubuntu 16.04 amd64: Failed

Topology Test Results are at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-TOPOU1604-2218/test

Topology Tests failed for Topology tests on Ubuntu 16.04 amd64:

2017-12-21 11:42:53,388 ERROR: ******************************************************************************
2017-12-21 11:42:53,389 ERROR: Test Target Summary                                                  Pass Fail
2017-12-21 11:42:53,389 ERROR: ******************************************************************************
2017-12-21 11:42:53,389 ERROR: 6    r3     See R1s address +10.06 secs                              0    1
2017-12-21 11:42:53,389 ERROR: 17   r1     Remote Registration +10.06 secs                          0    1
2017-12-21 11:42:53,389 ERROR: 19   r4     Remote Registration +10.14 secs                          0    1
2017-12-21 11:42:53,389 ERROR: 24   ce2    Local and remote routes +10.07 secs                      0    1
2017-12-21 11:42:53,389 ERROR: 30   r1     VPN SAFI                                                 0    1
2017-12-21 11:42:53,389 ERROR: 31   r2     VPN SAFI                                                 0    1
2017-12-21 11:42:53,389 ERROR: 32   r3     VPN SAFI                                                 0    1
2017-12-21 11:42:53,389 ERROR: 33   r4     VPN SAFI                                                 0    1
2017-12-21 11:42:53,389 ERROR: ******************************************************************************
2017-12-21 11:42:53,389 ERROR: Total 49                                                             32   8
2017-12-21 11:42:53,389 ERROR: ******************************************************************************
2017-12-21 11:42:53,390 ERROR: See /tmp/topotests/bgp_direct_to_bgp_vpn.test_bgp_direct_to_bgp_vpn/output.log for details of errors
2017-12-21 11:42:53,619 ERROR: assert failed at "bgp_direct_to_bgp_vpn.test_bgp_direct_to_bgp_vpn/test_run_lu_tests": 8 tests failed
assert '8 tests failed' == 'See summary output above'
  - 8 tests failed
  + See summary output above
r3: Daemon zebra not running

From frr r3 zebra log file:
ZEBRA: Received signal 11 at 1513885721 (si_addr 0x10, PC 0x55f93f767372); aborting...
Program counter: /usr/lib/frr/zebra(+0x35372)[0x55f93f767372]
Backtrace for 11 stack frames:
/usr/lib/libfrr.so.0(zlog_backtrace_sigsafe+0x48)[0x7f44a7a4f808]
/usr/lib/libfrr.so.0(zlog_signal+0x33b)[0x7f44a7a4ffeb]
/usr/lib/libfrr.so.0(+0x4c5ff)[0x7f44a7a635ff]
/lib/x86_64-linux-gnu/libpthread.so.0(+0x11390)[0x7f44a73f8390]
/usr/lib/frr/zebra(+0x35372)[0x55f93f767372]
/usr/lib/libfrr.so.0(work_queue_run+0xcc)[0x7f44a7a762ec]
/usr/lib/libfrr.so.0(thread_call+0x60)[0x7f44a7a6fc70]
/usr/lib/libfrr.so.0(frr_run+0xb8)[0x7f44a7a4e058]
/usr/lib/frr/zebra(main+0x27d)[0x55f93f744f2d]
/lib/x86_64-linux-gnu/libc.so.6(__libc_start_main+0xf0)[0x7f44a703d830]
/usr/lib/frr/zebra(_start+0x29)[0x55f93f7454b9]
in thread work_queue_run scheduled from lib/workqueue.c:134

see full log at https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2218/artifact/TOPOU1604/ErrorLog/log_topotests.txt

Topology Tests memory analysis: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2218/artifact/TOPOU1604/MemoryLeaks/

CLANG Static Analyzer Summary

  • Github Pull Request 1572, comparing to Git base SHA ff99c5b

No Changes in Static Analysis warnings compared to base

22 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2218/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2218/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 1572, comparing to Git base SHA ff99c5b

No Changes in Static Analysis warnings compared to base

22 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2218/artifact/shared/static_analysis/index.html

@NetDEF-CI
Copy link
Collaborator

Continuous Integration Result: SUCCESSFUL

Congratulations, this patch passed basic tests

Tested-by: NetDEF / OpenSourceRouting.org CI System

CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2219/

This is a comment from an EXPERIMENTAL automated CI system.
For questions and feedback in regards to this CI system, please feel free to email
Martin Winter - mwinter (at) opensourcerouting.org.

CLANG Static Analyzer Summary

  • Github Pull Request 1572, comparing to Git base SHA ff99c5b

No Changes in Static Analysis warnings compared to base

22 Static Analyzer issues remaining.

See details at
https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2219/artifact/shared/static_analysis/index.html

@riw777 riw777 merged commit d87c580 into FRRouting:master Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dslicenc @LabN-CI @NetDEF-CI @riw777