ospfd: do not complain if same area is reconfigured #1609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Daniel Walton <dwalton@cumulusnetworks.com> Before ------ cel-redxp-10(config)# router ospf vrf RED cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 There is already same network statement. cel-redxp-10(config-router)# When we see the "There is already same network statement." message vtysh exits non-zero. This scenario breaks frr-reload because the command took and it in the config, it should exit zero here. After ----- cel-redxp-10(config)# router ospf vrf RED cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0 cel-redxp-10(config-router)# network 1.1.1.1/32 area 0 cel-redxp-10(config-router)# cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.1 There is already same network statement. cel-redxp-10(config-router)#
Continuous Integration Result: SUCCESSFULCongratulations, this patch passed basic tests Tested-by: NetDEF / OpenSourceRouting.org CI System CI System Testrun URL: https://ci1.netdef.org/browse/FRR-FRRPULLREQ-2270/ This is a comment from an EXPERIMENTAL automated CI system. CLANG Static Analyzer Summary
No Changes in Static Analysis warnings compared to base21 Static Analyzer issues remaining.See details at |
💚 Basic BGPD CI results: SUCCESS, 0 tests failedResults table
For details, please contact louberger |
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Daniel Walton dwalton@cumulusnetworks.com
Before
cel-redxp-10(config)# router ospf vrf RED
cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0
cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0
There is already same network statement.
cel-redxp-10(config-router)#
When we see the "There is already same network statement." message
vtysh exits non-zero. This scenario breaks frr-reload because
the command took and it in the config, it should exit zero here.
After
cel-redxp-10(config)# router ospf vrf RED
cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0
cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0
cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.0
cel-redxp-10(config-router)# network 1.1.1.1/32 area 0
cel-redxp-10(config-router)#
cel-redxp-10(config-router)# network 1.1.1.1/32 area 0.0.0.1
There is already same network statement.
cel-redxp-10(config-router)#