Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bgpd: A couple more fixes for Tunnel encapsulation handling #16214

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

ton31337
Copy link
Member

No description provided.

Fixes: 79563af ("bgpd: Get 1 or 2 octets for Sub-TLV length (Tunnel Encap attr)")

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
…tlvs

When the packet is malformed it can use whatever values it wants. Let's check
what the real data we have in a stream instead of relying on malformed values.

Reported-by: Iggy Frankovic <iggyfran@amazon.com>
Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@ton31337
Copy link
Member Author

@Mergifyio backport dev/10.1 stable/10.0 stable/9.1

Copy link

mergify bot commented Jun 13, 2024

backport dev/10.1 stable/10.0 stable/9.1

✅ Backports have been created

@ton31337
Copy link
Member Author

@Mergifyio backport dev/10.1 stable/10.0 stable/9.1 stable/9.0 stable/8.5

@ton31337
Copy link
Member Author

ci:rerun CI wasn't triggered

Copy link

mergify bot commented Jun 13, 2024

backport dev/10.1 stable/10.0 stable/9.1 stable/9.0 stable/8.5

✅ Backports have been created

@ton31337 ton31337 added this to the 10.1 milestone Jun 13, 2024
@ton31337
Copy link
Member Author

ci:rerun

@donaldsharp donaldsharp self-requested a review June 18, 2024 15:20
Copy link
Member

@riw777 riw777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@riw777 riw777 merged commit aeeceef into FRRouting:master Jun 25, 2024
11 checks passed
riw777 added a commit that referenced this pull request Jun 25, 2024
bgpd: A couple more fixes for Tunnel encapsulation handling (backport #16214)
riw777 added a commit that referenced this pull request Jun 25, 2024
bgpd: A couple more fixes for Tunnel encapsulation handling (backport #16214)
@ton31337 ton31337 deleted the fix/attr_encap_handling branch June 25, 2024 11:32
riw777 added a commit that referenced this pull request Jun 25, 2024
bgpd: A couple more fixes for Tunnel encapsulation handling (backport #16214)
riw777 added a commit that referenced this pull request Jun 25, 2024
bgpd: A couple more fixes for Tunnel encapsulation handling (backport #16214)
riw777 added a commit that referenced this pull request Jun 25, 2024
bgpd: A couple more fixes for Tunnel encapsulation handling (backport #16214)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants