Commits on Jul 23, 2024

1. lib: mgmtd: fix too early daemon detach of mgmtd …

   Correct FRR startup counts on a daemon's vty socket to be open when the
   parent process exits. The parent process waits for `frr_check_detach()`
   to be called by the child before exiting. The problem is when the
   `FRR_MANUAL_VTY_START` flag is set the vty socket was not opened but
   `frr_check_detach()` was called anyway.
   
   Instead add a bool option for `frr_check_detach()` to be called when the
   socket is opened with `frr_vty_serv_start()`, and do so when "manually"
   calling said function (i.e., when FRR_MANUAL_VTY_START is set).
   
   The `FRR_MANUAL_VTY_START` flag is only set by mgmtd. The reason we
   wait to open the vty socket is so that mgmtd can parse the various
   daemon specific config files it has taken over, after the event loop has
   started, but before we receive any possible new config from `vtysh`.
   
   fixes FRRouting#16362
   
   Signed-off-by: Christian Hopps <chopps@labn.net>

   

   choppsv1 committed Jul 23, 2024
   Configuration menu

   • View commit details
   • Copy full SHA for be9a6fc
   • Browse repository at this point

   Copy the full SHA

   be9a6fc View commit details

   Browse the repository at this point in the history