zebra: Only notify dplane work pthread when needed #17062
+8
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
reviewed
Oct 11, 2024
zebra/dplane_fpm_nl.c
Outdated
| @@ -1512,8 +1514,12 @@ static void fpm_process_queue(struct event *t) | |||
|
|
|||
| /* Re-schedule if we ran out of buffer space */ | |||
| if (no_bufs) { | |||
| event_add_event(fnc->fthread->master, fpm_process_queue, fnc, 0, | |||
| &fnc->t_dequeue); | |||
| if (wrote_data) | |||
There was a problem hiding this comment.
Isn't enough to rely on processed_contexts instead of this additional wrote_data variable?
donaldsharp
force-pushed
the
dplane_fpm_nl_problems
branch
from
18fd5dd
to
c73d986
Compare
The fpm_nl_process function was getting the count of the total number of ctx's processed. This leads to after having processed 1 context to always signal the dataplane that there is work to do. Change the code to only notify the dplane worker when a context was actually added to the outgoing context queue. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
When the fpm_process_queue has run out of space but has written to the fpm output buffer, schedule it to wake up immediately, as that the write will go out pretty much immediately, since it was scheduled first. If the fpm_process_queue has not written to the output buffer then delay the processing by 10 milliseconds to allow a possibly backed up write processing to have a chance to complete it's work. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
Currently the max message size is 4k. With a 256 way ecmp FRR is seeing message sizes that are in the 6k size. There is desire to allow this to increase as well to 512. Since the multipath size directly effects how big the message may be when sending the routes ecmp let's give a bit of headroom for this value when compiling FRR at greater sizes. Additionally since we know not everyone is using such large ecmp, allow them to build as appropriate for their use cases. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
donaldsharp
force-pushed
the
dplane_fpm_nl_problems
branch
from
72c1a6b
to
cf2624a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fpm_nl_process function was getting the count
of the total number of ctx's processed. This leads to after having processed 1 context to always signal the dataplane that there is work to do. Change the code to only notify the dplane worker when a context was actually added to the outgoing context queue.