bgpd: Validate only affected RPKI prefixes instead of a full RIB #17586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ton31337
force-pushed
the
fix/revalidate_only_affected_routes
branch
from
6607e75 to
c8f7984
Compare
2 tasks
donaldsharp
reviewed
Dec 5, 2024
Before this fix, if rpki_sync_socket_rtr socket returns EAGAIN, then ALL routes in the RIB are revalidated which takes lots of CPU and some unnecessary traffic, e.g. if using BMP servers. With a full feed it would waste 50-80Mbps. Instead we should try to drain an existing pipe (another end), and revalidate only affected prefixes. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
ton31337
force-pushed
the
fix/revalidate_only_affected_routes
branch
from
c8f7984 to
b0800bf
Compare
|
https://github.com/Mergifyio backport stable/10.2 stable/10.1 stable/10.0 |
✅ Backports have been created
|
This was referenced Dec 20, 2024
ton31337
added a commit
that referenced
this pull request
Dec 20, 2024
bgpd: Validate only affected RPKI prefixes instead of a full RIB (backport #17586)
ton31337
added a commit
that referenced
this pull request
Dec 23, 2024
bgpd: Validate only affected RPKI prefixes instead of a full RIB (backport #17586)
|
Hey @ton31337, will this fix be backported to versions 8.5.5 and 9.1.1? |
|
Nope, not planned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17533